Fix serve_book when not running in RStudio#637
Merged
yihui merged 1 commit intorstudio:masterfrom Sep 26, 2018
Merged
Conversation
jimhester
force-pushed
the
serve_book-non-rstudio
branch
2 times, most recently
from
1f5e69f to
5044435
Compare
If the rstudioapi package is installed but serve_book is called outside of RStudio `getSourceEditorContext()` would signal an error. We now check if RStudio is available first, which fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the rstudioapi package is installed but serve_book is called outside
of RStudio
getSourceEditorContext()would signal an error.We now check if RStudio is available first, which fixes the issue.